Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709170

Re: [PATCH -next] zram: fix compr_data_size stat

Show all headers | View raw

On 2017/8/11 9:38, Sergey Senozhatsky wrote:
> On (08/11/17 10:35), Sergey Senozhatsky wrote:
>> On (08/11/17 09:10), Yisheng Xie wrote:
>>> The compr_data_size is a stat for compressed size of pages stored, which
>>> should add comp_len when we compresse a page.
>>>
>>> Meanwhile fix typos in comment:
>>> * ZRAM_SAME means page consists the same element not the entirely zero page
>>> * read_from_bdev_async() return 1 to avoid call page_endio() in zram_rw_page()
>>>
>>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>>
>> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> seems that some of the changes can be folded into the existing -next patches.

Yes, feel free to fold it :)

I find Minchan is removing zram_rw_page(), so maybe the return value of
read_from_bdev_async and write_to_bdev can be re-writed, it seems we need to
call page_endio() depend these return value anymore, after delete zram_rw_page().

Thanks
Yisheng Xie

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] zram: fix compr_data_size stat Yisheng Xie <xieyisheng1@huawei.com> - 2017-08-11 03:20 +0200
  Re: [PATCH -next] zram: fix compr_data_size stat Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-11 03:40 +0200
    Re: [PATCH -next] zram: fix compr_data_size stat Yisheng Xie <xieyisheng1@huawei.com> - 2017-08-11 04:20 +0200
      Re: [PATCH -next] zram: fix compr_data_size stat Yisheng Xie <xieyisheng1@huawei.com> - 2017-08-11 05:10 +0200
  Re: [PATCH -next] zram: fix compr_data_size stat Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-08-11 03:40 +0200

csiph-web