Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1706910
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method |
| Date | Wed, 09 Aug 2017 00:40:01 +0200 |
| Message-ID | <uclkl-6xM-9@gated-at.bofh.it> (permalink) |
| References | <ubGqS-2pI-15@gated-at.bofh.it> |
| X-Original-To | Jiandi An <anjiandi@codeaurora.org> |
| Dkim-Signature | v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=JBB7drGNBtonz0grEte8gMDTnwbug5Vls4DzfG1qDW8=; b=ImrzuDIvWr1rsmKoJ/VLiUju3szkJYkuQ6yDTPBu7h0jgT7l1b2VT83YHYetm3HJMPspyemhhrVYkvwFDMOG9SOExts0KuXd5CrtY60L9S9xWTh7Le5JXbEKkJUxEvpXIuFHooV03IuwE7TOuyRXPlm74HO5AVKDcy8NiF/9f6o=; |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 21 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 8 Aug 2017 16:36:43 -0600 |
| X-Original-Message-ID | <20170808223643.GD29372@obsidianresearch.com> |
| X-Original-References | <1502074455-4867-1-git-send-email-anjiandi@codeaurora.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1706910 |
Show key headers only | View raw
On Sun, Aug 06, 2017 at 09:54:15PM -0500, Jiandi An wrote:
> static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv *priv)
> {
> - if ((priv->flags & CRB_FL_ACPI_START) ||
> - (priv->flags & CRB_FL_CRB_SMC_START))
> + if (!(priv->flags & CRB_FL_CRB_START))
I think it would be better to have these list the cases where go_idle
is known to be required. Less brittle that way..
if ((priv->flags & (CRB_FL_ACPI_START | CRB_FL_CRB_START)) == 0)
return 0
> - if (!(priv->flags & CRB_FL_ACPI_START)) {
> + if (priv->flags & CRB_FL_CRB_START) {
Eg like this now makes more sense, assumming CRB_START is the right
test :)
Jason
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] tpm/tpm_crb: Access locality for only CRB_START method Jiandi An <anjiandi@codeaurora.org> - 2017-08-07 05:00 +0200 Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-08-09 00:40 +0200
csiph-web