Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method
Date	2017-08-09 00:40 +0200
Message-ID	<uclkl-6xM-9@gated-at.bofh.it> (permalink)
References	<ubGqS-2pI-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 06, 2017 at 09:54:15PM -0500, Jiandi An wrote:

>  static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv *priv)
>  {
> -	if ((priv->flags & CRB_FL_ACPI_START) ||
> -	    (priv->flags & CRB_FL_CRB_SMC_START))
> +	if (!(priv->flags & CRB_FL_CRB_START))

I think it would be better to have these list the cases where go_idle
is known to be required. Less brittle that way..

  if ((priv->flags & (CRB_FL_ACPI_START | CRB_FL_CRB_START)) == 0)
       return 0

> -	if (!(priv->flags & CRB_FL_ACPI_START)) {
> +	if (priv->flags & CRB_FL_CRB_START) {

Eg like this now makes more sense, assumming CRB_START is the right
test :)

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm/tpm_crb: Access locality for only CRB_START method Jiandi An <anjiandi@codeaurora.org> - 2017-08-07 05:00 +0200
  Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-08-09 00:40 +0200

csiph-web