[PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

From	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()
Date	2017-08-09 00:40 +0200
Message-ID	<uclkl-6xM-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

platform_get_irq() returns an error code, but the renesas_usb3 driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print error message and propagate the return value of platform_get_irq
on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index e1de8fe..616d053 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device *pdev)
 	priv = match->data;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0)
-		return -ENODEV;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
 
 	usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL);
 	if (!usb3)
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: udc: renesas_usb3: fix error return code in  renesas_usb3_probe() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-09 00:40 +0200
  RE: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in  renesas_usb3_probe() Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2017-08-09 13:50 +0200
    Re: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in  renesas_usb3_probe() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-10 05:20 +0200

csiph-web