Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702588

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

Show all headers | View raw

Hi Darren,

On Wed, 2 Aug 2017 16:57:40 -0700 Darren Hart <dvhart@infradead.org> wrote:
>
> Is this a new check Stephen?

Yes :-)

> Is there any statement regarding maintainer teams that we must abide by
> this?  e.g. any time a rebase in a testing branch is made, the
> maintainer must also ensure a SOB is on each patch?

I would say that if you rebase someone's commit(s), then you are on the
"patch's delivery path" and so should add a Signed-off-by tag. (cc'ing
Linus to see if he has an opinion.  Linus, the case here is a patch
originally committed by one maintainer and then rebased by the other.)

> I just want to get a clear picture of what the failure was so we can
> update our tooling so this doesn't repeat itself.

"git rebase" does have a "--signoff" option.

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-02 22:40 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 02:00 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 02:30 +0200
      Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-03 03:10 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 18:00 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-06 00:00 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Junio C Hamano <gitster@pobox.com> - 2017-08-04 19:50 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-04 19:50 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-03 10:20 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 11:30 +0200

csiph-web