Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702580

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

Show all headers | View raw

On Thu, Aug 03, 2017 at 06:37:43AM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> Commits
> 
>   890f658c101d ("platform/x86: peaq-wmi: silence a static checker warning")
>   6d8d55626296 ("platform/x86: msi-wmi: remove unnecessary static in msi_wmi_notify()")
>   cd0223c64c60 ("platform/x86: ibm_rtl: remove unnecessary static in ibm_rtl_write()")
> 
> are missing Signed-off-by's from their commiter.

So each of these was originally committed by Andy... but appear as
committed by me. This must have occured as a rebase of our testing
branch I suppose. Nothing has been out of the ordinary this development
cycle, so I wonder that we haven't received such a report previously.
Hrm.

Is this a new check Stephen?

Is there any statement regarding maintainer teams that we must abide by
this?  e.g. any time a rebase in a testing branch is made, the
maintainer must also ensure a SOB is on each patch?

I just want to get a clear picture of what the failure was so we can
update our tooling so this doesn't repeat itself.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-02 22:40 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 02:00 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 02:30 +0200
      Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-03 03:10 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 18:00 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-06 00:00 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Junio C Hamano <gitster@pobox.com> - 2017-08-04 19:50 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-04 19:50 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-03 10:20 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 11:30 +0200

csiph-web