Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree
Date	2017-08-03 03:10 +0200
Message-ID	<uacOd-Z0-1@gated-at.bofh.it> (permalink)
References	<ua8AV-6r3-1@gated-at.bofh.it> <uabIt-8u0-3@gated-at.bofh.it> <uacbv-sE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 2, 2017 at 5:28 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> I would say that if you rebase someone's commit(s), then you are on the
> "patch's delivery path" and so should add a Signed-off-by tag.

Yeah, I agree. Rebasing really is pretty much the exact same thing as
applying a patch.

> "git rebase" does have a "--signoff" option.

I think you end up signing off twice using that. I don't think it's
smart enough to say "oh, you already did it once".

But I didn't check. Sometimes git is a lot smarter than I remember it
being, simply because I don't worry about it. Junio does a good job.

And in general, you simply should never rebase commits that have
already been publicized. And the fact that you didn't commit them in
the first place definitely means that they've been public somewhere.

So I would definitely suggest against the "git rebase --signoff"
model, even if git were to do the "right thing". It's simply
fundamentally the wrong thing to do. Either you already committed them
(and hopefully signed off correctly the first time), or you didn't
(and you shouldn't be rebasing). So in neither case is "git rebase
--signoff" sensible.

              Linus

Thread

linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-02 22:40 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 02:00 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 02:30 +0200
      Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-03 03:10 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-03 18:00 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-06 00:00 +0200
        Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree Junio C Hamano <gitster@pobox.com> - 2017-08-04 19:50 +0200
          Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Darren Hart <dvhart@infradead.org> - 2017-08-04 19:50 +0200
  Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-03 10:20 +0200
    Re: linux-next: Signed-off-by missing for commit in the drivers-x86  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-03 11:30 +0200

csiph-web