Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699796

Re: [PATCH 00/29] constify scsi pci_device_id.

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH 00/29] constify scsi pci_device_id.
Date Mon, 31 Jul 2017 10:00:02 +0200
Message-ID <u9dMm-3vs-13@gated-at.bofh.it> (permalink)
References <u8RVv-6lw-5@gated-at.bofh.it>
X-Original-To Arvind Yadav <arvind.yadav.cs@gmail.com>
MIME-Version 1.0
Content-Type text/plain; charset=iso-8859-1
Content-Disposition inline
Content-Transfer-Encoding 8bit
User-Agent Mutt/1.5.24 (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 18
Organization linux.* mail to news gateway
X-Original-Cc martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, mdr@sgi.com, hare@suse.com, aacraid@adaptec.com, matthew@wil.cx, fthain@telegraphics.com.au, schmitzmic@gmail.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, gotom@debian.or.jp, mrochs@linux.vnet.ibm.com, yokota@netlab.is.tsukuba.ac.jp, QLogic-Storage-Upstream@cavium.com, jinpu.wang@profitbricks.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Mon, 31 Jul 2017 09:56:47 +0200
X-Original-Message-ID <20170731075647.GB4316@linux-x5ow.site>
X-Original-References <1501403839-8876-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1699796

Show key headers only | View raw


On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.

Can't this go all in one patch instead of replicating the same patch 29
times?

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  [PATCH 09/29] scsi: arcmsr: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 10:00 +0200
    Re: [PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-31 11:00 +0200
      Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 11:30 +0200
        Re: [PATCH 00/29] constify scsi pci_device_id. "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-07 19:40 +0200
          Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-08 08:40 +0200

csiph-web