Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699441 > unrolled thread

[PATCH 00/29] constify scsi pci_device_id.

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-07-30 10:40 +0200
Last post2017-08-08 08:40 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
    [PATCH 09/29] scsi: arcmsr: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
    [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
    Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 10:00 +0200
      Re: [PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-31 11:00 +0200
        Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 11:30 +0200
          Re: [PATCH 00/29] constify scsi pci_device_id. "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-07 19:40 +0200
            Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-08 08:40 +0200

#1699441 — [PATCH 00/29] constify scsi pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-30 10:40 +0200
Subject[PATCH 00/29] constify scsi pci_device_id.
Message-ID<u8RVv-6lw-5@gated-at.bofh.it>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (29):
  [PATCH 01/29] scsi: qla1280: constify pci_device_id.
  [PATCH 02/29] scsi: qedi: constify pci_device_id.
  [PATCH 03/29] scsi: am53c974: constify pci_device_id.
  [PATCH 04/29] scsi: pm8001: constify pci_device_id.
  [PATCH 05/29] scsi: qla4xxx: constify pci_device_id.
  [PATCH 06/29] scsi: mvsas: constify pci_device_id.
  [PATCH 07/29] scsi: 3w-9xxx: constify pci_device_id.
  [PATCH 08/29] scsi: ipr: constify pci_device_id.
  [PATCH 09/29] scsi: arcmsr: constify pci_device_id.
  [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id.
  [PATCH 11/29] scsi: 3w-sas: constify pci_device_id.
  [PATCH 12/29] scsi: hptiop: constify pci_device_id.
  [PATCH 13/29] scsi: fdomain: constify pci_device_id.
  [PATCH 14/29] scsi: snic: constify pci_device_id.
  [PATCH 15/29] scsi: sym53c8xx_2: constify pci_device_id.
  [PATCH 16/29] scsi: esas2r: constify pci_device_id.
  [PATCH 17/29] scsi: qla2xxx: constify pci_device_id.
  [PATCH 18/29] scsi: dmx3191d: constify pci_device_id.
  [PATCH 19/29] scsi: megaraid: constify pci_device_id.
  [PATCH 20/29] scsi: cxlflash: constify pci_device_id.
  [PATCH 21/29] scsi: nsp32: constify pci_device_id.
  [PATCH 22/29] scsi: pmcraid: constify pci_device_id.
  [PATCH 23/29] scsi: fnic: constify pci_device_id.
  [PATCH 24/29] scsi: stex: constify pci_device_id.
  [PATCH 25/29] scsi: megaraid: constify pci_device_id.
  [PATCH 26/29] scsi: a100u2w: constify pci_device_id.
  [PATCH 27/29] scsi: advansys: constify pci_device_id.
  [PATCH 28/29] scsi: atp870u: constify pci_device_id.
  [PATCH 29/29] scsi: 3w-xxxx: constify pci_device_id.

 drivers/scsi/3w-9xxx.c                    | 2 +-
 drivers/scsi/3w-sas.c                     | 2 +-
 drivers/scsi/3w-xxxx.c                    | 2 +-
 drivers/scsi/a100u2w.c                    | 2 +-
 drivers/scsi/advansys.c                   | 2 +-
 drivers/scsi/am53c974.c                   | 2 +-
 drivers/scsi/arcmsr/arcmsr_hba.c          | 2 +-
 drivers/scsi/atp870u.c                    | 2 +-
 drivers/scsi/cxlflash/main.c              | 2 +-
 drivers/scsi/dmx3191d.c                   | 2 +-
 drivers/scsi/dpt_i2o.c                    | 2 +-
 drivers/scsi/esas2r/esas2r_main.c         | 2 +-
 drivers/scsi/fdomain.c                    | 2 +-
 drivers/scsi/fnic/fnic_main.c             | 2 +-
 drivers/scsi/hptiop.c                     | 2 +-
 drivers/scsi/ipr.c                        | 2 +-
 drivers/scsi/megaraid.c                   | 2 +-
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
 drivers/scsi/mvsas/mv_init.c              | 2 +-
 drivers/scsi/nsp32.c                      | 2 +-
 drivers/scsi/pm8001/pm8001_init.c         | 2 +-
 drivers/scsi/pmcraid.c                    | 2 +-
 drivers/scsi/qedi/qedi_main.c             | 2 +-
 drivers/scsi/qla1280.c                    | 2 +-
 drivers/scsi/qla2xxx/qla_os.c             | 2 +-
 drivers/scsi/qla4xxx/ql4_os.c             | 2 +-
 drivers/scsi/snic/snic_main.c             | 2 +-
 drivers/scsi/stex.c                       | 2 +-
 drivers/scsi/sym53c8xx_2/sym_glue.c       | 2 +-
 29 files changed, 29 insertions(+), 29 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1699442 — [PATCH 09/29] scsi: arcmsr: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-30 10:40 +0200
Subject[PATCH 09/29] scsi: arcmsr: constify pci_device_id.
Message-ID<u8RVw-6lw-25@gated-at.bofh.it>
In reply to#1699441
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index af032c4..392fb07 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -141,7 +141,7 @@ static struct scsi_host_template arcmsr_scsi_host_template = {
 	.no_write_same		= 1,
 };
 
-static struct pci_device_id arcmsr_device_id_table[] = {
+static const struct pci_device_id arcmsr_device_id_table[] = {
 	{PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1110),
 		.driver_data = ACB_ADAPTER_TYPE_A},
 	{PCI_DEVICE(PCI_VENDOR_ID_ARECA, PCI_DEVICE_ID_ARECA_1120),
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1699443 — [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-30 10:40 +0200
Subject[PATCH 10/29] scsi: dpt_i2o: constify pci_device_id.
Message-ID<u8RVw-6lw-27@gated-at.bofh.it>
In reply to#1699441
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/scsi/dpt_i2o.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..ba90cc4 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -181,7 +181,7 @@ static u8 adpt_read_blink_led(adpt_hba* host)
  */
 
 #ifdef MODULE
-static struct pci_device_id dptids[] = {
+static const struct pci_device_id dptids[] = {
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ 0, }
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1699796

FromJohannes Thumshirn <jthumshirn@suse.de>
Date2017-07-31 10:00 +0200
Message-ID<u9dMm-3vs-13@gated-at.bofh.it>
In reply to#1699441
On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.

Can't this go all in one patch instead of replicating the same patch 29
times?

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1699832

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-07-31 11:00 +0200
Message-ID<u9eIq-44A-21@gated-at.bofh.it>
In reply to#1699796

On Monday 31 July 2017 01:26 PM, Johannes Thumshirn wrote:
> On Sun, Jul 30, 2017 at 02:07:09PM +0530, Arvind Yadav wrote:
>> pci_device_id are not supposed to change at runtime. All functions
>> working with pci_device_id provided by <linux/pci.h> work with
>> const pci_device_id. So mark the non-const structs as const.
> Can't this go all in one patch instead of replicating the same patch 29
> times?
Yes, We can add all of them in single patch. But other maintainer wants
single single patch. thats why I have send 29 patch. :(
> Thanks,
> 	Johannes
>
~arvind

[toc] | [prev] | [next] | [standalone]

#1699854

FromJohannes Thumshirn <jthumshirn@suse.de>
Date2017-07-31 11:30 +0200
Message-ID<u9fbs-4uw-17@gated-at.bofh.it>
In reply to#1699832
On Mon, Jul 31, 2017 at 02:23:11PM +0530, Arvind Yadav wrote:
> Yes, We can add all of them in single patch. But other maintainer wants
> single single patch. thats why I have send 29 patch. :(

Ultimately it's up to Martin and James but I don't see a hughe benefit in
having it all in a separate patch.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1705735

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2017-08-07 19:40 +0200
Message-ID<ubUau-3mF-17@gated-at.bofh.it>
In reply to#1699854
Johannes,

> Ultimately it's up to Martin and James but I don't see a hughe benefit
> in having it all in a separate patch.

Generally speaking, I prefer driver maintainers to be able to sign off
on changes to their code. So I tend to lean towards a per-driver
grouping.

However, having a bazillion identical commit messages is also really
annoying. So for automated changes like this, I'd rather just have a
single patch.

It needs to have a really good and comprehensive commit messages that
justifies the (sub) tree-wide change, though...

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [next] | [standalone]

#1706064

FromJohannes Thumshirn <jthumshirn@suse.de>
Date2017-08-08 08:40 +0200
Message-ID<uc6lj-3ZY-11@gated-at.bofh.it>
In reply to#1705735
On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote:
> However, having a bazillion identical commit messages is also really
> annoying. So for automated changes like this, I'd rather just have a
> single patch.

Thought so ;-)

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web