Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699443

[PATCH 10/29] scsi: dpt_i2o: constify pci_device_id.

Show all headers | View raw

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/scsi/dpt_i2o.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..ba90cc4 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -181,7 +181,7 @@ static u8 adpt_read_blink_led(adpt_hba* host)
  */
 
 #ifdef MODULE
-static struct pci_device_id dptids[] = {
+static const struct pci_device_id dptids[] = {
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
 	{ 0, }
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  [PATCH 09/29] scsi: arcmsr: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  [PATCH 10/29] scsi: dpt_i2o: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:40 +0200
  Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 10:00 +0200
    Re: [PATCH 00/29] constify scsi pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-31 11:00 +0200
      Re: [PATCH 00/29] constify scsi pci_device_id. Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-31 11:30 +0200

csiph-web