Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
Date	2017-08-01 16:00 +0200
Message-ID	<u9FSj-4Gv-17@gated-at.bofh.it> (permalink)
References	<u9FSj-4Gv-19@gated-at.bofh.it> <u4PyV-3WT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15426	   4952	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15490	   4888	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] video: fbdev: uvesafb: constify attribute_group  structures. Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-08-01 16:00 +0200

csiph-web