Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1701080 > unrolled thread

Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.

Started byBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
First post2017-08-01 16:00 +0200
Last post2017-08-01 16:00 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] video: fbdev: uvesafb: constify attribute_group  structures. Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-08-01 16:00 +0200

#1701080 — Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.

FromBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date2017-08-01 16:00 +0200
SubjectRe: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
Message-ID<u9FSj-4Gv-17@gated-at.bofh.it>
On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15426	   4952	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15490	   4888	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web