Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698757

Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf

Show all headers | View raw

On Fri, 28 Jul 2017 12:51:40 +0200
Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Jul 28, 2017 at 09:09:33AM +0200, Borislav Petkov wrote:
> > On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote:  
> > > What happens if two CPUs have mce's at the same time? Wouldn't one
> > > corrupt the other buffer. 128 isn't too big to put on the stack is it?  
> > 
> > Yeah, putting it on the stack is probably safer, just in case.
> > 
> > What is even better, though, is if I extended
> > arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the
> > decoded strings. We use it for the struct mces right now.  
> 
> Here's a conversion to a 2-page backed genpool. Seems to work:

Interesting, this is the first I heard of the genpool. I probably could
have used this in other code. Good to know (learn something new every
day :-)

I'll have to take a look at it when I get home later today (still
bouncing between airports).

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
    Re: [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
  [RFC PATCH 1/8] EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 3/8] EDAC, mce_amd: Get rid of local var in amd_filter_mce() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 8/8] EDAC, mce_amd: Issue the decoded info through the TP or printk Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
  [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
  [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping  a decoded string Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
      Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a  decoded string Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
  [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
      Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
        Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 13:00 +0200
          Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 15:10 +0200
            Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 16:20 +0200
  Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-27 09:20 +0200
    Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-27 10:00 +0200
      Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-27 10:40 +0200
        Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-27 15:10 +0200
          Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-28 08:40 +0200
            Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
              Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:10 +0200
                Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:40 +0200
      RE: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error "Luck, Tony" <tony.luck@intel.com> - 2017-07-27 18:50 +0200
        Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:30 +0200

csiph-web