Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698550
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf |
| Date | 2017-07-28 09:20 +0200 |
| Message-ID | <u87J1-CM-27@gated-at.bofh.it> (permalink) |
| References | <u7afT-4DI-9@gated-at.bofh.it> <u7apB-4Hw-51@gated-at.bofh.it> <u82zE-5vS-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 27, 2017 at 09:47:08PM -0400, Steven Rostedt wrote:
> What happens if two CPUs have mce's at the same time? Wouldn't one
> corrupt the other buffer. 128 isn't too big to put on the stack is it?
Yeah, putting it on the stack is probably safer, just in case.
What is even better, though, is if I extended
arch/x86/kernel/cpu/mcheck/mce-genpool.c to allocate a second buffer for the
decoded strings. We use it for the struct mces right now.
And 1-2 pages should be fine:
8192 / 128 = 64 decoded strings in flight.
I guess that should cover most situations. Famous last words.
In any case, thanks for pointing this out.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
[RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
Re: [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
[RFC PATCH 1/8] EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
[RFC PATCH 3/8] EDAC, mce_amd: Get rid of local var in amd_filter_mce() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
[RFC PATCH 8/8] EDAC, mce_amd: Issue the decoded info through the TP or printk Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
[RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
Re: [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
[RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
[RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 13:00 +0200
Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 15:10 +0200
Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 16:20 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Ingo Molnar <mingo@kernel.org> - 2017-07-27 09:20 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-27 10:00 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Ingo Molnar <mingo@kernel.org> - 2017-07-27 10:40 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-27 15:10 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Ingo Molnar <mingo@kernel.org> - 2017-07-28 08:40 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:10 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:40 +0200
RE: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error "Luck, Tony" <tony.luck@intel.com> - 2017-07-27 18:50 +0200
Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:30 +0200
csiph-web