Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error
Date	2017-07-27 09:20 +0200
Message-ID	<u7Lfs-37f-1@gated-at.bofh.it> (permalink)
References	<u7afT-4DI-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> Hi,
> 
> here's a first stab at adding a tracepoint which dumps the decoded MCE
> string to userspace. The main idea is to have the decoding functionality
> in the kernel and depending on whether you have userspace consumers
> listening or not, to dump the error to the tracepoint or to dmesg.
> 
> In either case, we do the decoding in the kernel and don't need special
> userspace. Furthermore, adding new CPU support will have to be done only
> in one place.
> 
> First 6 patches are cleanups which are good to have regardless, IMO.
> 
> Any constructive comments and suggestions are appreciated.
> 
> Thanks.
> 
> P.S., Thanks to Rostedt for the input!
> 
> Borislav Petkov (8):
>   EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error()
>   EDAC, mce_amd: Get rid of most struct cpuinfo_x86 uses
>   EDAC, mce_amd: Get rid of local var in amd_filter_mce()
>   seq_buf: Add seq_buf_clear_buf()
>   seq_buf: Export seq_buf_printf() to modules
>   EDAC, mce_amd: Convert to seq_buf
>   EDAC, mce_amd: Add a simple tracepoint dumping a decoded string
>   EDAC, mce_amd: Issue the decoded info through the TP or printk
> 
>  drivers/edac/mce_amd.c  | 285 +++++++++++++++++++++++++++---------------------
>  drivers/ras/ras.c       |   1 +
>  include/linux/seq_buf.h |   7 ++
>  include/ras/ras_event.h |  16 +++
>  lib/seq_buf.c           |   1 +
>  5 files changed, 186 insertions(+), 124 deletions(-)

Looks pretty nice to me conceptually. Do you have a couple of examples of 
real-life events that get logged? It's hard to decode it from the new tracepoint 
alone.

Thanks,

	Ingo

Thread

[RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
    Re: [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf() Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
  [RFC PATCH 1/8] EDAC, mce_amd: Rename decode_smca_errors() to decode_smca_error() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 3/8] EDAC, mce_amd: Get rid of local var in amd_filter_mce() Borislav Petkov <bp@alien8.de> - 2017-07-25 17:50 +0200
  [RFC PATCH 8/8] EDAC, mce_amd: Issue the decoded info through the TP or printk Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
  [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 5/8] seq_buf: Export seq_buf_printf() to modules Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
  [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a decoded string Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping  a decoded string Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
      Re: [RFC PATCH 7/8] EDAC, mce_amd: Add a simple tracepoint dumping a  decoded string Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
  [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-25 18:00 +0200
    Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 03:50 +0200
      Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
        Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 13:00 +0200
          Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Steven Rostedt <rostedt@goodmis.org> - 2017-07-28 15:10 +0200
            Re: [RFC PATCH 6/8] EDAC, mce_amd: Convert to seq_buf Borislav Petkov <bp@alien8.de> - 2017-07-28 16:20 +0200
  Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-27 09:20 +0200
    Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-27 10:00 +0200
      Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-27 10:40 +0200
        Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-27 15:10 +0200
          Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Ingo Molnar <mingo@kernel.org> - 2017-07-28 08:40 +0200
            Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:20 +0200
              Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:10 +0200
                Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 17:40 +0200
      RE: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error "Luck, Tony" <tony.luck@intel.com> - 2017-07-27 18:50 +0200
        Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded  error Borislav Petkov <bp@alien8.de> - 2017-07-28 09:30 +0200

csiph-web