Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1698683

[PATCH v2] staging:wlan-ng Correct multiple line dereference

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From janani-sankarababu <jananis37@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2] staging:wlan-ng Correct multiple line dereference
Date Fri, 28 Jul 2017 12:50:01 +0200
Message-ID <u8b0d-2Ab-3@gated-at.bofh.it> (permalink)
X-Original-To gregkh@linuxfoundation.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yTr8g1xmNaPdJm3GSEKlmU8SJHxxN4mRYrymy9OLytQ=; b=nCtpOZCNEQne7g5D0ETCGV+idnNnFyL0uXXB3nMAz7COMdfAsQ3HWmcqDhgpEvP+92 9VWe/uH/5q5GJqAremd8vJ3LYu4OQBFWSO5FY8MFLoRJbA4uOwKIUtRHs16xprHO0GJX Z+3ISJBfgc1+d4fZFGWBDwEsE4QfJS+Re9m6AOkzeisil8VgvQlbyKRNKtEfWHFXI04N 15Lb0mhr2lT11Sa1WPFDnHNHajxBNvHa9TiTjdkStQ6QJFWt8g/FuxArvCZ4OnH4OyO2 jUsM/vPnxRTWOJTPSC6ti0mJoJnWhB9ti2fGVNQWzpJnli8LgU5N+Yloe2fiAQf2tj69 2BlQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yTr8g1xmNaPdJm3GSEKlmU8SJHxxN4mRYrymy9OLytQ=; b=DklHV0kN1SQXJSoH0Wpl4DQg4HiUOburTAn3BUEH7r7klVTh+T0T/PWs3TzjCNguWF 6P5rcC0/1AIZw7Aui/ltZ7JCVP6aNLjp5yA4kBdcdSqMbhwLrSV7JVuUYJBwjphzQNCO 7TGHsSwkSYTwABCGZ8Vo4V2ygjnFfgKYMPXvrwGT0gZK3e2vhrBuSk4ZslWGPhmuYD+z UeIhhLK6Pl1XVxuflohugUeyobdFDiB5oiGbILqi1vIveLcbVCw+WE04LIGrxpP53Wk1 Hn+kHrEYRCIJI20If07Z0fFwcwj8Cu28+lzKYtLh8NSVtfqZJeirb8eqiHdtCLJtzAiN Q7cg==
X-Gm-Message-State AIVw110v5wRqahbkrmfRy0wuIUIsOU2KaOqQ0+cZJvQY0wQ4Rmb0cyvw mEhY6FznSyDVFg==
X-Received by 10.98.139.134 with SMTP id e6mr6964914pfl.111.1501238938192; Fri, 28 Jul 2017 03:48:58 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc sergio.paracuellos@gmail.com, davem@davemloft.net, adrien.descamps@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, janani-sankarababu <jananis37@gmail.com>
X-Original-Date Fri, 28 Jul 2017 16:14:29 +0530
X-Original-Message-ID <1501238669-28142-1-git-send-email-jananis37@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1698683

Show key headers only | View raw


This patch fixes the multiple line dereference Warning reported by
checkpath script. This has been made to simplify the code and make
it more readable.

Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2fc5f3e 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
 		kfree(ctlx);
 	} else if (mode == DOWAIT) {
 		struct usbctlx_cmd_completor completor;
+		struct usbctlx_completor *cmplt;
+
+		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+					   &cmd->result);

-		result =
-		    hfa384x_usbctlx_complete_sync(hw, ctlx,
-						  init_cmd_completor(&completor,
-								     &ctlx->
-								     inbuf.
-								     cmdresp,
-								     &cmd->
-								     result));
+		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
 	}

done:
--
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] staging:wlan-ng Correct multiple line dereference janani-sankarababu <jananis37@gmail.com> - 2017-07-28 12:50 +0200
  Re: [PATCH v2] staging:wlan-ng Correct multiple line dereference Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-28 13:10 +0200

csiph-web