Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698682

[PATCH] w1: constify attribute_group structures.

Show all headers | View raw

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 74471e7..0f614df 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -568,7 +568,7 @@ static ssize_t w1_master_attribute_store_remove(struct device *dev,
 	NULL
 };
 
-static struct attribute_group w1_master_defattr_group = {
+static const struct attribute_group w1_master_defattr_group = {
 	.attrs = w1_master_default_attrs,
 };
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] w1: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-28 12:40 +0200

csiph-web