Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698683 > unrolled thread
| Started by | janani-sankarababu <jananis37@gmail.com> |
|---|---|
| First post | 2017-07-28 12:50 +0200 |
| Last post | 2017-07-28 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] staging:wlan-ng Correct multiple line dereference janani-sankarababu <jananis37@gmail.com> - 2017-07-28 12:50 +0200
Re: [PATCH v2] staging:wlan-ng Correct multiple line dereference Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-28 13:10 +0200
| From | janani-sankarababu <jananis37@gmail.com> |
|---|---|
| Date | 2017-07-28 12:50 +0200 |
| Subject | [PATCH v2] staging:wlan-ng Correct multiple line dereference |
| Message-ID | <u8b0d-2Ab-3@gated-at.bofh.it> |
This patch fixes the multiple line dereference Warning reported by
checkpath script. This has been made to simplify the code and make
it more readable.
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2fc5f3e 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+ struct usbctlx_completor *cmplt;
+
+ cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+ &cmd->result);
- result =
- hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(&completor,
- &ctlx->
- inbuf.
- cmdresp,
- &cmd->
- result));
+ result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}
done:
--
1.9.1
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-07-28 13:10 +0200 |
| Message-ID | <u8bjz-2W9-1@gated-at.bofh.it> |
| In reply to | #1698683 |
From header. Subject. Doesn't apply (read Documentation/process/email-clients.rst). On Fri, Jul 28, 2017 at 04:14:29PM +0530, janani-sankarababu wrote: > This patch fixes the multiple line dereference Warning reported by > checkpath script. This has been made to simplify the code and make > it more readable. > > Signed-off-by: Janani Sankara Babu <jananis37@gmail.com> > --- Put a changelog under the --- cut off: v3: patch format issues regards, dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web