Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690569

Re: [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate

Show all headers | View raw

2017-07-18 19:17 GMT+09:00 Jonas Gorski <jonas.gorski@gmail.com>:
> Make the behaviour of clk_get_rate consistent with common clk's
> clk_get_rate by accepting NULL clocks as parameter. Some device
> drivers rely on this, and will cause an OOPS otherwise.
>
> Fixes: 969003152aa9 ("blackfin: bf60x: add clock support")
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

This Cc can be replaced with

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Thank you.


> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: adi-buildroot-devel@lists.sourceforge.net
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Mathias Kresin <dev@kresin.me>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
>  arch/blackfin/mach-bf609/clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/mach-bf609/clock.c b/arch/blackfin/mach-bf609/clock.c
> index 392a59b9a504..21a0ec18829f 100644
> --- a/arch/blackfin/mach-bf609/clock.c
> +++ b/arch/blackfin/mach-bf609/clock.c
> @@ -109,7 +109,7 @@ EXPORT_SYMBOL(clk_disable);
>  unsigned long clk_get_rate(struct clk *clk)
>  {
>         unsigned long ret = 0;
> -       if (clk->ops && clk->ops->get_rate)
> +       if (clk && clk->ops && clk->ops->get_rate)
>                 ret = clk->ops->get_rate(clk);
>         return ret;
>  }
> --
> 2.11.0
>



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] make clk_get_rate implementations behavior more consistent Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 2/9] ARM: mmp: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Greg Ungerer <gerg@linux-m68k.org> - 2017-07-18 14:10 +0200
      Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-19 11:10 +0200
        Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Greg Ungerer <gerg@linux-m68k.org> - 2017-07-19 14:30 +0200
  [PATCH 5/9] MIPS: AR7: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 6/9] MIPS: BCM63XX: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 6/9] MIPS: BCM63XX: allow NULL clock for clk_get_rate Florian Fainelli <f.fainelli@gmail.com> - 2017-07-18 22:00 +0200
  [PATCH 9/9] unicore32: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-18 21:00 +0200
  [PATCH 7/9] MIPS: Loongson 2F: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate Alexander Sverdlin <alexander.sverdlin@gmail.com> - 2017-07-19 07:10 +0200
  Re: [PATCH 0/9] make clk_get_rate implementations behavior more consistent Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-18 14:10 +0200

csiph-web