Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690969

Re: [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate

Show all headers | View raw

On 18/07/17 12:17, Jonas Gorski wrote:
> Make the behaviour of clk_get_rate consistent with common clk's
> clk_get_rate by accepting NULL clocks as parameter. Some device
> drivers rely on this, and will cause an OOPS otherwise.
> 
> Fixes: 1d81eedb8f6c ("[ARM] 3634/1: ep93xx: initial implementation of the clk_* API")
> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Reported-by: Mathias Kresin <dev@kresin.me>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  arch/arm/mach-ep93xx/clock.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-ep93xx/clock.c b/arch/arm/mach-ep93xx/clock.c
> index 39ef3b613912..f0768befafe8 100644
> --- a/arch/arm/mach-ep93xx/clock.c
> +++ b/arch/arm/mach-ep93xx/clock.c
> @@ -316,6 +316,9 @@ static unsigned long get_uart_rate(struct clk *clk)
>  
>  unsigned long clk_get_rate(struct clk *clk)
>  {
> +	if (!clk)
> +		return 0;
> +
>  	if (clk->get_rate)
>  		return clk->get_rate(clk);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] make clk_get_rate implementations behavior more consistent Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 2/9] ARM: mmp: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Greg Ungerer <gerg@linux-m68k.org> - 2017-07-18 14:10 +0200
      Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-19 11:10 +0200
        Re: [PATCH 4/9] m68k: allow NULL clock for clk_get_rate Greg Ungerer <gerg@linux-m68k.org> - 2017-07-19 14:30 +0200
  [PATCH 5/9] MIPS: AR7: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 6/9] MIPS: BCM63XX: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 6/9] MIPS: BCM63XX: allow NULL clock for clk_get_rate Florian Fainelli <f.fainelli@gmail.com> - 2017-07-18 22:00 +0200
  [PATCH 9/9] unicore32: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 3/9] blackfin: bf609: allow NULL clock for clk_get_rate Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-18 21:00 +0200
  [PATCH 7/9] MIPS: Loongson 2F: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
  [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate Jonas Gorski <jonas.gorski@gmail.com> - 2017-07-18 12:20 +0200
    Re: [PATCH 1/9] ARM: ep93xx: allow NULL clock for clk_get_rate Alexander Sverdlin <alexander.sverdlin@gmail.com> - 2017-07-19 07:10 +0200
  Re: [PATCH 0/9] make clk_get_rate implementations behavior more consistent Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-18 14:10 +0200

csiph-web