Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690568

Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result

Show all headers | View raw

On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..05907fa8a553 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
>  	if (!intel_dp_link_training_channel_equalization(intel_dp))
>  		goto failure_handling;
>  
> -	DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> +	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> +		      intel_connector->base.base.id,
> +		      intel_connector->base.name,
>  		      intel_dp->link_rate, intel_dp->lane_count);
>  	return;
>  
>   failure_handling:
> -	DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> +	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> +		      intel_connector->base.base.id,
> +		      intel_connector->base.name,
>  		      intel_dp->link_rate, intel_dp->lane_count);
>  	if (!intel_dp_get_link_train_fallback_values(intel_dp,
>  						     intel_dp->link_rate,


Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

The choice of upper v/s lower case letters in these debug messages is a
bit odd.

Passed/failed
Link rate/link rate
Lane count/lane count

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] drm/i915: Explicit the connector name for DP link training result Paul Kocialkowski <paul.kocialkowski@linux.intel.com> - 2017-07-18 16:30 +0200
  Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name  for DP link training result "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com> - 2017-07-18 21:00 +0200
  Re: [PATCH v2] drm/i915: Explicit the connector name for DP link  training result Manasi Navare <manasi.d.navare@intel.com> - 2017-07-18 21:20 +0200
    Re: [PATCH v2] drm/i915: Explicit the connector name for DP link  training result Daniel Vetter <daniel@ffwll.ch> - 2017-07-19 08:40 +0200
    Re: [PATCH v2] drm/i915: Explicit the connector name for DP link  training result Paul Kocialkowski <paul.kocialkowski@linux.intel.com> - 2017-07-19 10:40 +0200
      Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Jani Nikula <jani.nikula@linux.intel.com> - 2017-07-19 11:00 +0200

csiph-web