Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687900

Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator binding

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> This adds the binding document describing the three hardware blocks
> related to the Light Pulse Generator found in a wide range of Qualcomm
> PMICs.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> 
> Changes since v1:
> - Dropped custom pattern properties
> - Renamed cell-index to qcom,lpg-channel to clarify its purpose
> 
>  .../devicetree/bindings/leds/leds-qcom-lpg.txt     | 145 +++++++++++++++++++++
>  1 file changed, 145 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-qcom-lpg.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.txt b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.txt
> new file mode 100644
> index 000000000000..cc9ffee6586b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.txt
> @@ -0,0 +1,145 @@
> +Binding for Qualcomm Light Pulse Generator
> +

Can we use similar format to other files in the directory?

> +The Qualcomm Light Pulse Generator consists of three different hardware blocks;
> +a ramp generator with lookup table, the light pulse generator and a three
> +channel current sink. These blocks are found in a wide range of Qualcomm PMICs.
> +Each of these are described individually below.
> +
> += Lookup Table (LUT)
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "qcom,spmi-lpg-lut"

I guess we don't need to know type of the compatible atribute, other
files say

Required properties:

- compatible : Must be "skyworks,aat1290".
- flen-gpios : Must be device tree identifier of the flash device
...

which is easier to understand.

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-17 06:50 +0200
        Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
          Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 02:10 +0200
  [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
        Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:20 +0200
          Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
            Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 01:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 22:00 +0200
  [PATCH v2 2/3] leds: Add driver for Qualcomm LPG Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
    Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
      Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
        Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:00 +0200
          Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 23:20 +0200

csiph-web