Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688120

Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator

Show all headers | View raw

On Sat 15 Jul 02:10 PDT 2017, Pavel Machek wrote:

> Hi!
> 
> > This series introduces a generic pattern interface in the LED class and a
> > driver for the Qualcomm Light Pulse Generator.
> > 
> > Bjorn Andersson (3):
> >   leds: core: Introduce generic pattern interface
> 
> This one should be last. Let me review that, it is important to get
> this one right.
> 
> >   leds: Add driver for Qualcomm LPG
> 
> >   DT: leds: Add Qualcomm Light Pulse Generator binding
> 
> This one should be first.
> 

Okay, no problems.

> And I guess I'd prefer the driver to go in first, before the generic
> pattern interface.
> 

The driver won't compile without the additions to the header file. Would
you like the rest of the driver to go in first, then the generic
interface and finally the pattern part of the driver?

Large portions of the driver doesn't make sense without the pattern
part, so I think I would prefer it to go in as one patch.

Please let me know and I'll update the series.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-17 06:50 +0200
        Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
          Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 02:10 +0200
  [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
        Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:20 +0200
          Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
            Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 01:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 22:00 +0200
  [PATCH v2 2/3] leds: Add driver for Qualcomm LPG Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
    Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
      Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
        Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:00 +0200
          Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 23:20 +0200

csiph-web