Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator
Date	2017-07-16 23:20 +0200
Message-ID	<u3Z7k-4i4-23@gated-at.bofh.it> (permalink)
References	<u3hzj-1sg-3@gated-at.bofh.it> <u3rp0-82B-7@gated-at.bofh.it> <u3KrD-31n-7@gated-at.bofh.it> <u3MjM-4aC-11@gated-at.bofh.it> <u3YNZ-3W3-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> > > > >   DT: leds: Add Qualcomm Light Pulse Generator binding
> > > > 
> > > > This one should be first.
> > > > 
> > > 
> > > Okay, no problems.
> > > 
> > > > And I guess I'd prefer the driver to go in first, before the generic
> > > > pattern interface.
> > > > 
> > > 
> > > The driver won't compile without the additions to the header file. Would
> > > you like the rest of the driver to go in first, then the generic
> > > interface and finally the pattern part of the driver?
> > > 
> > > Large portions of the driver doesn't make sense without the pattern
> > > part, so I think I would prefer it to go in as one patch.
> > 
> > Can we get minimum driver without the pattern parts?
> 
> It's possible to do, but I must admit I find it slightly contrived.
> 
> The overall design of different parts of the driver does relate to how I
> decided to structure and implement the pattern support, so this would
> mean that the driver we merge has a conceptual dependency on a
> out-of-tree part.

Ok... but I guess that's something we can live with?

> May I ask about the reasoning for your request? Is it just to not leave
> the driver hanging while we conclude the discussion on the pattern
> interface?

Yes; it would be good to have driver in the tree. OTOH new userland
interface is a "big" decission, and we'll have to support the
interface "forever" once it is merged.

Actually even complete driver (but w/o the userland interface) would
be acceptable. Drivers we can fix. Userland interfaces... not so.

Best regards,
   	       	       	      	   	    		      Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
    Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
      Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-17 06:50 +0200
        Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
          Re: [PATCH v2 3/3] DT: leds: Add Qualcomm Light Pulse Generator  binding Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 02:10 +0200
  [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
    Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-16 21:00 +0200
        Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:20 +0200
          Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-07-17 23:10 +0200
            Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-18 01:40 +0200
      Re: [PATCH v2 1/3] leds: core: Introduce generic pattern interface Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 22:00 +0200
  [PATCH v2 2/3] leds: Add driver for Qualcomm LPG Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-15 00:50 +0200
  Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-15 11:20 +0200
    Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 07:40 +0200
      Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 09:40 +0200
        Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-16 23:00 +0200
          Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator Pavel Machek <pavel@ucw.cz> - 2017-07-16 23:20 +0200

csiph-web