Re: [PATCH] tracing/ring_buffer: Try harder to allocate

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tracing/ring_buffer: Try harder to allocate
Date	2017-07-11 19:30 +0200
Message-ID	<u278Z-5cu-7@gated-at.bofh.it> (permalink)
References	<u1WwV-74G-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 10, 2017 at 11:05:00PM -0700, Joel Fernandes wrote:
> ftrace can fail to allocate per-CPU ring buffer on systems with a large
> number of CPUs coupled while large amounts of cache happening in the
> page cache. Currently the ring buffer allocation doesn't retry in the VM
> implementation even if direct-reclaim made some progress but still
> wasn't able to find a free page. On retrying I see that the allocations
> almost always succeed. The retry doesn't happen because __GFP_NORETRY is
> used in the tracer to prevent the case where we might OOM, however if we
> drop __GFP_NORETRY, we risk destabilizing the system if OOM killer is
> triggered. To prevent this situation, use the __GFP_RETRY_MAYFAIL flag
> introduced recently [1].
> 
> Tested the following still succeeds without destabilizing a system with
> 1GB memory.
> echo 300000 > /sys/kernel/debug/tracing/buffer_size_kb
> 
> [1] https://marc.info/?l=linux-mm&m=149820805124906&w=2
> 
> Cc: Alexander Duyck <alexander.h.duyck@intel.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Hao Lee <haolee.swjtu@gmail.com>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Tim Murray <timmurray@google.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Joel Fernandes <joelaf@google.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tracing/ring_buffer: Try harder to allocate Joel Fernandes <joelaf@google.com> - 2017-07-11 08:10 +0200
  Re: [PATCH] tracing/ring_buffer: Try harder to allocate Michal Hocko <mhocko@kernel.org> - 2017-07-11 08:20 +0200
  Re: [PATCH] tracing/ring_buffer: Try harder to allocate Vlastimil Babka <vbabka@suse.cz> - 2017-07-11 08:20 +0200
  Re: [PATCH] tracing/ring_buffer: Try harder to allocate Johannes Weiner <hannes@cmpxchg.org> - 2017-07-11 19:30 +0200

csiph-web