Re: [PATCH] staging: ks7010: fix styling WARNINGs

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: ks7010: fix styling WARNINGs
Date	2017-07-11 19:30 +0200
Message-ID	<u278Z-5cu-11@gated-at.bofh.it> (permalink)
References	<tXWc9-KG-15@gated-at.bofh.it> <tXX8e-1pk-5@gated-at.bofh.it> <tY8ZH-w7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
> 
> I agree with all of your comments. Do you think the best course of
> action is to create a new patch with this change alone and forget the
> rest?
> 
> -       DPRINTK(1, "ks7010_sdio_remove()\n");
> +       DPRINTK(1, "%s()\n", __func__);

Lines like this, that are just "here I am!" comments, should all be
deleted anyway, we have ftrace in the kernel, people always seem to
forget about it...

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: ks7010: fix styling WARNINGs Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 19:30 +0200

csiph-web