RE: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

From	"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128
Date	2017-07-11 19:30 +0200
Message-ID	<u278Z-5cu-1@gated-at.bofh.it> (permalink)
References	<u1Zbr-8vM-3@gated-at.bofh.it> <u1Zbs-8vM-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h
> @@ -115,7 +115,7 @@
> 
>  #define MPT3SAS_RAID_MAX_SECTORS	8192
>  #define MPT3SAS_HOST_PAGE_SIZE_4K	12
> -
> +#define MPT3SAS_NVME_QUEUE_DEPTH	128
...
> +		/*TODO-right Queue Depth?*/
> +		qdepth = MPT3SAS_NVME_QUEUE_DEPTH;
> +		ds = "NVMe";

The native NVMe driver is getting a modparam to set that value (rather than
using a #define of 1024) in this patch:
	http://lists.infradead.org/pipermail/linux-nvme/2017-July/011734.html

Perhaps this driver should do the same.

---
Robert Elliott, HPE Persistent Memory

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128 Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-07-11 11:00 +0200
  RE: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128 "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2017-07-11 19:30 +0200

csiph-web