Re: [PATCH] f2fs: relax permission for atomic/volatile ioctls

From	Eric Biggers <ebiggers3@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] f2fs: relax permission for atomic/volatile ioctls
Date	2017-07-07 04:10 +0200
Message-ID	<u0qSt-5wZ-1@gated-at.bofh.it> (permalink)
References	<u04Ii-6v1-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 07:23:26PM -0700, Jaegeuk Kim wrote:
> This patch allows atomic/volatile ioctls for sqlite under sdcardfs.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/file.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f5d6357e8360..dd8f5d2caa48 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -

Why not require that the file be open for writing (FMODE_WRITE)?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: relax permission for atomic/volatile ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-06 04:30 +0200
  Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Chao Yu <chao@kernel.org> - 2017-07-07 02:10 +0200
    Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-07 02:20 +0200
      Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Chao Yu <chao@kernel.org> - 2017-07-07 03:00 +0200
        Re: 答复: [f2fs-dev] [PATCH]  f2fs: relax permission for atomic/volatile ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-07 04:20 +0200
          Re: 答复: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls "gaoxiang (P)" <gaoxiang25@huawei.com> - 2017-07-07 04:30 +0200
  Re: [PATCH] f2fs: relax permission for atomic/volatile ioctls Eric Biggers <ebiggers3@gmail.com> - 2017-07-07 04:10 +0200

csiph-web