Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1682819

Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls

From Chao Yu <chao@kernel.org>
Newsgroups linux.kernel
Subject Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls
Date 2017-07-07 02:10 +0200
Message-ID <u0p0l-4n9-7@gated-at.bofh.it> (permalink)
References <u04Ii-6v1-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017/7/6 10:23, Jaegeuk Kim wrote:
> This patch allows atomic/volatile ioctls for sqlite under sdcardfs.

Out of curiosity, we will lose some capable when passing through sdcardfs?

Thanks,

> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>> ---
>  fs/f2fs/file.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f5d6357e8360..dd8f5d2caa48 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -
>  	if (!S_ISREG(inode->i_mode))
>  		return -EINVAL;
>  
> @@ -1636,9 +1633,6 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -
>  	ret = mnt_want_write_file(filp);
>  	if (ret)
>  		return ret;
> @@ -1672,9 +1666,6 @@ static int f2fs_ioc_start_volatile_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -
>  	if (!S_ISREG(inode->i_mode))
>  		return -EINVAL;
>  
> @@ -1707,9 +1698,6 @@ static int f2fs_ioc_release_volatile_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -
>  	ret = mnt_want_write_file(filp);
>  	if (ret)
>  		return ret;
> @@ -1736,9 +1724,6 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)
>  	struct inode *inode = file_inode(filp);
>  	int ret;
>  
> -	if (!inode_owner_or_capable(inode))
> -		return -EACCES;
> -
>  	ret = mnt_want_write_file(filp);
>  	if (ret)
>  		return ret;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] f2fs: relax permission for atomic/volatile ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-06 04:30 +0200
  Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Chao Yu <chao@kernel.org> - 2017-07-07 02:10 +0200
    Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-07 02:20 +0200
      Re: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile  ioctls Chao Yu <chao@kernel.org> - 2017-07-07 03:00 +0200
        Re: 答复: [f2fs-dev] [PATCH]  f2fs: relax permission for atomic/volatile ioctls Jaegeuk Kim <jaegeuk@kernel.org> - 2017-07-07 04:20 +0200
          Re: 答复: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls "gaoxiang (P)" <gaoxiang25@huawei.com> - 2017-07-07 04:30 +0200
  Re: [PATCH] f2fs: relax permission for atomic/volatile ioctls Eric Biggers <ebiggers3@gmail.com> - 2017-07-07 04:10 +0200

csiph-web