Re: [PATCH 12/18] drivers: s390: Move static and inline before return type

From	Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/18] drivers: s390: Move static and inline before return type
Date	2017-07-06 12:30 +0200
Message-ID	<u0ccO-32q-27@gated-at.bofh.it> (permalink)
References	<tZYMx-2CG-3@gated-at.bofh.it> <tZYMz-2CG-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote:
> Make the code like the rest of the kernel.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/s390/net/ctcm_main.c    | 2 +-
>  drivers/s390/net/qeth_l3_main.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)


> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 3062cde33a3d..8975cd321390 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -2408,7 +2408,7 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
>  	return rc;
>  }
> 
> -int inline qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
> +inline int qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
>  {

Actually the function could be made static, and "inline" should be removed,
considering the large function body.

Thread

[PATCH 00/18] treewide: Move storage class before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 09/18] MIPS: SMP: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 11/18] x86/efi: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 12/18] drivers: s390: Move static and inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 12:30 +0200
      Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Joe Perches <joe@perches.com> - 2017-07-06 13:00 +0200
        Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 14:30 +0200
          Re: [PATCH 12/18] drivers: s390: Move static and inline before return  type Julian Wiedmann <jwi@linux.vnet.ibm.com> - 2017-07-06 20:10 +0200
  [PATCH 01/18] checkpatch: improve the STORAGE_CLASS test Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 07/18] ia64: sn: pci: Move inline before type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 18/18] ALSA: opl4: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Clemens Ladisch <clemens@ladisch.de> - 2017-07-05 22:40 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Takashi Iwai <tiwai@suse.de> - 2017-07-06 09:30 +0200
  [PATCH 17/18] ARM: samsung: usb-ohci: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 13/18] drivers: tty: serial: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 15/18] video: fbdev: intelfb: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 03/18] ARM: HP Jornada 7XX: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200

csiph-web