Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682350

Re: [PATCH 12/18] drivers: s390: Move static and inline before return type

Show all headers | View raw

On Thu, 2017-07-06 at 12:29 +0200, Heiko Carstens wrote:
> On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote:
> > Make the code like the rest of the kernel.
[]
> > diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.cqq
[]
> > @@ -2408,7 +2408,7 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
> >  	return rc;
> >  }
> > 
> > -int inline qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
> > +inline int qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
> >  {
> 
> Actually the function could be made static, and "inline" should be removed,
> considering the large function body.

I agree to a certain extent.

It's only used once and  it looks like Klaus-Dieter Wacker
just missed adding static to this function.

$ git log --stat -p -1 ce73e10ee0cb6
commit ce73e10ee0cb6cde1c5075a2803da0f0eb5b2324
Author: Klaus-Dieter Wacker <kdwacker@de.ibm.com>

But it also looks like inline is too often used in several
drivers/s390/net/*.c files, where most of those static inline
functions are only used once.

$ git grep -w inline drivers/s390/net/*.c | wc -l
42

Maybe inline removals should be a separate pass for all those.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] treewide: Move storage class before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 09/18] MIPS: SMP: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 11/18] x86/efi: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 12/18] drivers: s390: Move static and inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 12:30 +0200
      Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Joe Perches <joe@perches.com> - 2017-07-06 13:00 +0200
        Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 14:30 +0200
          Re: [PATCH 12/18] drivers: s390: Move static and inline before return  type Julian Wiedmann <jwi@linux.vnet.ibm.com> - 2017-07-06 20:10 +0200
  [PATCH 01/18] checkpatch: improve the STORAGE_CLASS test Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 07/18] ia64: sn: pci: Move inline before type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 18/18] ALSA: opl4: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Clemens Ladisch <clemens@ladisch.de> - 2017-07-05 22:40 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Takashi Iwai <tiwai@suse.de> - 2017-07-06 09:30 +0200
  [PATCH 17/18] ARM: samsung: usb-ohci: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 13/18] drivers: tty: serial: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 15/18] video: fbdev: intelfb: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 03/18] ARM: HP Jornada 7XX: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200

csiph-web