Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681773

[PATCH 15/18] video: fbdev: intelfb: Move inline before return type

Show all headers | View raw

Make the code like the rest of the kernel.

But there is an oddity here because the inline should probably be removed.

It's an extern function in intelfb.h and it is used in intelfbdrv.c and
intelfbhw.c.

The inline is kept here as I suppose it's possible for some compiler to
make the uses inline in intelfbdrv and and also create an external function
for intelfbhw.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400a86c..ffc391208b27 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -907,7 +907,7 @@ static void intelfb_pci_unregister(struct pci_dev *pdev)
  *                       helper functions                      *
  ***************************************************************/
 
-int __inline__ intelfb_var_to_depth(const struct fb_var_screeninfo *var)
+__inline__ int intelfb_var_to_depth(const struct fb_var_screeninfo *var)
 {
 	DBG_MSG("intelfb_var_to_depth: bpp: %d, green.length is %d\n",
 		var->bits_per_pixel, var->green.length);
-- 
2.10.0.rc2.1.g053435c

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/18] treewide: Move storage class before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 09/18] MIPS: SMP: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 11/18] x86/efi: Move asmlinkage before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 12/18] drivers: s390: Move static and inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 12:30 +0200
      Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Joe Perches <joe@perches.com> - 2017-07-06 13:00 +0200
        Re: [PATCH 12/18] drivers: s390: Move static and inline before  return type Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-07-06 14:30 +0200
          Re: [PATCH 12/18] drivers: s390: Move static and inline before return  type Julian Wiedmann <jwi@linux.vnet.ibm.com> - 2017-07-06 20:10 +0200
  [PATCH 01/18] checkpatch: improve the STORAGE_CLASS test Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 07/18] ia64: sn: pci: Move inline before type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 18/18] ALSA: opl4: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Clemens Ladisch <clemens@ladisch.de> - 2017-07-05 22:40 +0200
    Re: [PATCH 18/18] ALSA: opl4: Move inline before return type Takashi Iwai <tiwai@suse.de> - 2017-07-06 09:30 +0200
  [PATCH 17/18] ARM: samsung: usb-ohci: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 13/18] drivers: tty: serial: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 15/18] video: fbdev: intelfb: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200
  [PATCH 03/18] ARM: HP Jornada 7XX: Move inline before return type Joe Perches <joe@perches.com> - 2017-07-05 22:10 +0200

csiph-web