Re: [git pull] vfs.git part 1

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [git pull] vfs.git part 1
Date	2017-07-08 01:00 +0200
Message-ID	<u0Ko9-2b0-5@gated-at.bofh.it> (permalink)
References	<tZMLn-3av-3@gated-at.bofh.it> <u0DPK-63n-33@gated-at.bofh.it> <u0DPK-63n-31@gated-at.bofh.it> <u0Fou-7c6-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> The copy_flock_fields() macro has the arguments in order <from, to>,
>> but all the users seem to do it the other way around.
>
> Looking more at it, I think I'd also like copy_flock_fields() to take
> pointer arguments, to match all the code around it (both
> copy_to/from_user and the memset calls.
>
> The actual order of arguments I suspect Michael's patch did better -
> make the copy_flock_fields() just match the order of memcpy() and
> copy_to/from_user(), both of which have <dest,src> order.
>
> So I think my preferred patch would be something like this, even if it
> is bigger than either.
>
> Comments? Michael, does this work for your case?

Yeah that works, as committed in your tree. Sorry for the slow reply,
our time zones don't line up all that well :)

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-05 09:20 +0200
  Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:40 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 19:40 +0200
      Re: [git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-07 21:10 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200

csiph-web