Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683342

Re: [git pull] vfs.git part 1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The copy_flock_fields() macro has the arguments in order <from, to>,
> but all the users seem to do it the other way around.

Looking more at it, I think I'd also like copy_flock_fields() to take
pointer arguments, to match all the code around it (both
copy_to/from_user and the memset calls.

The actual order of arguments I suspect Michael's patch did better -
make the copy_flock_fields() just match the order of memcpy() and
copy_to/from_user(), both of which have <dest,src> order.

So I think my preferred patch would be something like this, even if it
is bigger than either.

Comments? Michael, does this work for your case?

              Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-05 09:20 +0200
  Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:40 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 19:40 +0200
      Re: [git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-07 21:10 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200

csiph-web