Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683270

Re: [git pull] vfs.git part 1

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jul 7, 2017 at 5:46 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Al Viro <viro@ZenIV.linux.org.uk> writes:
>
>>
>>   Switch flock copyin/copyout primitives to copy_{from,to}_user() (2017-06-26 23:52:44 -0400)
>
> This commit seems to have broken networking on a bunch of my PPC
> machines (64-bit kernel, 32-bit userspace).

Bah. I think that commit is entirely broken, due to having the
arguments to the "copy_flock_fields()" in the wrong order.

The copy_flock_fields() macro has the arguments in order <from, to>,
but all the users seem to do it the other way around.

I think it would have been more obvious if the put_compat_flock*()
source argument had been "const".

> Patch coming.

I'm not seeing a patch, so I did my own. But it's _entirely_ untested.
Does the attached fix things for you?

                     Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-05 09:20 +0200
  Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 18:40 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200
    Re: [git pull] vfs.git part 1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 19:40 +0200
      Re: [git pull] vfs.git part 1 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-07 21:10 +0200
      Re: [git pull] vfs.git part 1 Michael Ellerman <mpe@ellerman.id.au> - 2017-07-08 01:00 +0200

csiph-web