Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.
Date	2017-04-24 17:20 +0200
Message-ID	<tzNWq-ba-5@gated-at.bofh.it> (permalink)
References	<tyd8C-4Wq-7@gated-at.bofh.it> <tyd8C-4Wq-25@gated-at.bofh.it> <tyEVb-5ck-3@gated-at.bofh.it> <tzBse-8uT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote:
> 
> I was following the existing practice exemplified by
> bioset_create_nobvec().

Which is pretty ugly to start with..

> By not changing the signature of the function, I can avoid touching
> quite a few places where it is called.

There are 13 callers of bioset_create and one caller of
bioset_create_nobvec, and your series touches many of those.

So just adding a flags argument to bioset_create and passing
BIOSET_NEED_BVECS and BIOSET_NEED_RESUER flags to it doesn't seem
to much of an effort, and it's going to create a much nicer and easier
to extend interface.

Thread

[PATCH 02/11] blk: make the bioset rescue_workqueue optional. NeilBrown <neilb@suse.com> - 2017-04-20 07:50 +0200
  Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. Christoph Hellwig <hch@infradead.org> - 2017-04-21 13:30 +0200
    Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. NeilBrown <neilb@suse.com> - 2017-04-24 04:00 +0200
      Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. Christoph Hellwig <hch@infradead.org> - 2017-04-24 17:20 +0200
        Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. NeilBrown <neilb@suse.com> - 2017-05-01 07:10 +0200
          Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. Jens Axboe <axboe@kernel.dk> - 2017-05-01 16:10 +0200
            Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional. NeilBrown <neilb@suse.com> - 2017-05-02 05:40 +0200

csiph-web