Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626671

Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused

Show all headers | View raw

On Wed, Apr 19, 2017 at 07:37:09PM +0200, Arnd Bergmann wrote:
> In some rare randconfig builds, we end up with two functions being entirely
> unused:
> 
> drivers/clocksource/arm_arch_timer.c:342:12: error: 'erratum_set_next_event_tval_phys' defined but not used [-Werror=unused-function]
>  static int erratum_set_next_event_tval_phys(unsigned long evt,
> drivers/clocksource/arm_arch_timer.c:335:12: error: 'erratum_set_next_event_tval_virt' defined but not used [-Werror=unused-function]
>  static int erratum_set_next_event_tval_virt(unsigned long evt,
> 
> We could add an #ifdef around them, but we would already have to check for
> several symbols there and there is a chance this would get more complicated
> over time, so marking them as __maybe_unused is the simplest way to avoid the
> harmless warnings.
> 
> Fixes: 01d3e3ff2608 ("arm64: arch_timer: Rework the set_next_event workarounds")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-04-19 19:40 +0200
  Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Marc Zyngier <marc.zyngier@arm.com> - 2017-04-19 20:10 +0200
  Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-19 20:20 +0200
  [tip:timers/core] arm64/arch_timer: Mark errata handlers as  __maybe_unused tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2017-04-20 15:20 +0200

csiph-web