Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1626666
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused |
| Date | 2017-04-19 20:10 +0200 |
| Message-ID | <ty2dc-6Gz-21@gated-at.bofh.it> (permalink) |
| References | <ty1K9-6hB-13@gated-at.bofh.it> |
| Organization | ARM Ltd |
On 19/04/17 18:37, Arnd Bergmann wrote:
> In some rare randconfig builds, we end up with two functions being entirely
> unused:
>
> drivers/clocksource/arm_arch_timer.c:342:12: error: 'erratum_set_next_event_tval_phys' defined but not used [-Werror=unused-function]
> static int erratum_set_next_event_tval_phys(unsigned long evt,
> drivers/clocksource/arm_arch_timer.c:335:12: error: 'erratum_set_next_event_tval_virt' defined but not used [-Werror=unused-function]
> static int erratum_set_next_event_tval_virt(unsigned long evt,
>
> We could add an #ifdef around them, but we would already have to check for
> several symbols there and there is a chance this would get more complicated
> over time, so marking them as __maybe_unused is the simplest way to avoid the
> harmless warnings.
>
> Fixes: 01d3e3ff2608 ("arm64: arch_timer: Rework the set_next_event workarounds")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Ah, well spotted. You need CONFIG_ARM64_ERRATUM_858921, but none of
CONFIG_HISILICON_ERRATUM_161010101 or CONFIG_FSL_ERRATUM_A008585.
Dreadful stuff.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-04-19 19:40 +0200 Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Marc Zyngier <marc.zyngier@arm.com> - 2017-04-19 20:10 +0200 Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-19 20:20 +0200 [tip:timers/core] arm64/arch_timer: Mark errata handlers as __maybe_unused tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2017-04-20 15:20 +0200
csiph-web