Re: [PATCH] power: supply: charger manager: refactor return statements

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] power: supply: charger manager: refactor return statements
Date	Tue, 11 Apr 2017 16:30:01 +0200
Message-ID	<tv4XT-8aE-1@gated-at.bofh.it> (permalink)
References	<tqnyb-ea-55@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ktahkoelamnsavcv"
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	MyungJoo Ham <myungjoo.ham@samsung.com>, Jiri Kosina <trivial@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>, Andi Shyti <andi.shyti@samsung.com>
X-Original-Date	Tue, 11 Apr 2017 16:28:29 +0200
X-Original-Message-ID	<20170411142829.ymplbmjbqswqxin5@earth>
X-Original-References	<20170329151357.1841-1-andi@etezian.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1621340

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Thu, Mar 30, 2017 at 12:13:57AM +0900, Andi Shyti wrote:
> Some trivial improvements on the returning value of the
> functions:
> 
>  - remove unnecessary goto labels that just return, return
>    immediately, instead.
> 
>  - do not initialize when not needed.
> 
>  - return the value from the calling function that fails instead
>    of politically choosing -EINVAL.
> 
> Signed-off-by: Andi Shyti <andi@etezian.org>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] power: supply: charger manager: refactor return  statements Sebastian Reichel <sre@kernel.org> - 2017-04-11 16:30 +0200

csiph-web