Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621340 > unrolled thread

Re: [PATCH] power: supply: charger manager: refactor return statements

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] power: supply: charger manager: refactor return  statements Sebastian Reichel <sre@kernel.org> - 2017-04-11 16:30 +0200

#1621340 — Re: [PATCH] power: supply: charger manager: refactor return statements

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Thu, Mar 30, 2017 at 12:13:57AM +0900, Andi Shyti wrote:
> Some trivial improvements on the returning value of the
> functions:
> 
>  - remove unnecessary goto labels that just return, return
>    immediately, instead.
> 
>  - do not initialize when not needed.
> 
>  - return the value from the calling function that fails instead
>    of politically choosing -EINVAL.
> 
> Signed-off-by: Andi Shyti <andi@etezian.org>

Thanks, queued.

-- Sebastian

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web