Re: [PATCH] power: supply: charger manager: refactor return statements

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] power: supply: charger manager: refactor return statements
Date	2017-04-11 16:30 +0200
Message-ID	<tv4XT-8aE-1@gated-at.bofh.it> (permalink)
References	<tqnyb-ea-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Thu, Mar 30, 2017 at 12:13:57AM +0900, Andi Shyti wrote:
> Some trivial improvements on the returning value of the
> functions:
> 
>  - remove unnecessary goto labels that just return, return
>    immediately, instead.
> 
>  - do not initialize when not needed.
> 
>  - return the value from the calling function that fails instead
>    of politically choosing -EINVAL.
> 
> Signed-off-by: Andi Shyti <andi@etezian.org>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] power: supply: charger manager: refactor return  statements Sebastian Reichel <sre@kernel.org> - 2017-04-11 16:30 +0200

csiph-web