Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618022
| From | Juergen Borleis <jbe@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support |
| Date | 2017-04-06 15:50 +0200 |
| Message-ID | <ttfXs-HN-15@gated-at.bofh.it> (permalink) |
| References | <tsPqh-Mk-1@gated-at.bofh.it> <tsPqi-Mk-21@gated-at.bofh.it> <tsXQR-69Y-1@gated-at.bofh.it> |
| Organization | Pengutronix e.K. |
Hi Andrew,
On Wednesday 05 April 2017 20:21:55 Andrew Lunn wrote:
> [...]
> > +SMSC/MicroChip LAN9303 three port ethernet switch
> > +-------------------------------------------------
> > +
> > +Required properties:
> > +
> > +- compatible: should be "smsc,lan9303"
> > +- #size-cells: must be 0
> > +- #address-cells: must be 1
> > +
> > +Optional properties:
> > +
> > +- phy-reset-gpios: GPIO to be used to reset the whole device, always low active
> > +- phy-reset-duration: reset duration, defaults to 200 ms
>
> It is good to state the unit, ms.
Done in v2.
> [...]
> > + master: masterdevice@X {
> > + phy-handle = <ðphy>;
> > + status = "okay";
> > +
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethphy: ethernet-phy@0 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <0>;
> > + max-speed = <100>;
> > + };
>
> If there is RMII between the CPU interface and the switch, why is this
> PHY needed?
Tested and changed to "fixed-link" in v2.
> [...]
> > + switch: switch@a {
> > + compatible = "smsc,lan9303";
> > + reg = <0xa>;
> > + status = "okay";
> > + interrupts-extended = <&gpio2 7 IRQ_TYPE_LEVEL_LOW>;
>
> This interrupt is not in the binding documentation, or the code.
Leftover from development. Removed in v2.
> > + phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
> > + phy-reset-duration = <200>;
> > +
> > + dsa,member = <0 0>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 { /* RMII fixed link to master */
> > + reg = <0>;
> > + label = "cpu";
> > + ethernet = <&master>;
> > + max-speed = <100>;
>
> max-speed does not do anything i think, since there is no adjust_link
> function.
Removed in v2.
Thanks.
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis <jbe@pengutronix.de> - 2017-04-05 11:30 +0200
[PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-05 11:30 +0200
Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-05 20:20 +0200
Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-06 12:30 +0200
Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-06 14:00 +0200
Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-06 15:50 +0200
Re: [PATCH 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-06 12:50 +0200
[PATCH 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-05 11:30 +0200
Re: [PATCH 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-05 19:20 +0200
Re: [PATCH 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-06 15:40 +0200
[PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-05 11:30 +0200
Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-05 20:30 +0200
Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-06 15:50 +0200
Re: [PATCH 3/4] net: dsa: LAN9303: add I2C managed mode support Florian Fainelli <f.fainelli@gmail.com> - 2017-04-06 16:00 +0200
[PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-05 11:30 +0200
Re: [PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-05 21:40 +0200
Re: [PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support Florian Fainelli <f.fainelli@gmail.com> - 2017-04-06 16:00 +0200
Re: [PATCH 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-06 16:30 +0200
csiph-web