Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS

Path	csiph.com!xmission!feeder.awxg.com!aioe.org!bofh.it!news.nic.it!robomod
From	Joerg Roedel <jroedel@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS
Date	Fri, 07 Apr 2017 14:40:01 +0200
Message-ID	<ttBlf-746-5@gated-at.bofh.it> (permalink)
References	<tpYgq-7p2-7@gated-at.bofh.it> <tszOy-7qW-19@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Joerg Roedel <joro@8bytes.org>, Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>, Alexander Deucher <Alexander.Deucher@amd.com>
X-Original-Date	Fri, 7 Apr 2017 14:34:31 +0200
X-Original-Message-ID	<20170407123431.GC23944@suse.de>
X-Original-References	<1490703404-4944-1-git-send-email-joro@8bytes.org> <20170404164311.GB27692@bhelgaas-glaptop.roam.corp.google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1618732

Show key headers only | View raw

Hi Bjorn,

On Tue, Apr 04, 2017 at 11:43:11AM -0500, Bjorn Helgaas wrote:
> > +static const struct pci_device_id broken_ats_tbl[] = {
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x98e4) }, /* AMD Stoney GPU part */

Just found out that the affected GPU uses PCI_VENDOR_ID_ATI, fixed that
too.

> > +	{ 0 }
> > +};
> > +
> >  void pci_ats_init(struct pci_dev *dev)
> > 
> >  	int pos;
> >  
> > +	if (pci_match_id(broken_ats_tbl, dev))
> > +		return;
> 
> This is fine functionally, but from a stylistic point of view, I guess
> I would prefer to have it implemented in drivers/pci/quirks.c just to
> have some consistency in how we work around device defects.

Done, I send a new patch shortly.



	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <joro@8bytes.org> - 2017-03-28 14:20 +0200
  RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:20 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-03-28 22:30 +0200
      RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:40 +0200
        Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-28 23:00 +0200
          RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 23:20 +0200
            Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 00:30 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 09:20 +0200
                Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 11:50 +0200
                RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 11:50 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-29 18:30 +0200
  Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Bjorn Helgaas <helgaas@kernel.org> - 2017-04-04 18:50 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-04-07 14:40 +0200

csiph-web