Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS

From	'Joerg Roedel' <jroedel@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS
Date	2017-03-29 00:30 +0200
Message-ID	<tq7MK-5VB-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <tq5KW-4td-21@gated-at.bofh.it> <tq5UC-4xD-15@gated-at.bofh.it> <tq64h-4CD-15@gated-at.bofh.it> <tq6nD-4K6-9@gated-at.bofh.it> <tq6GZ-586-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 28, 2017 at 09:13:23PM +0000, Deucher, Alexander wrote:
> If I understand Arindam's patch correctly, it only flushes TLB entries
> for domains in the flush queue whereas the previous behavior was to
> flush all domains.  If there was no TLB flush in the queue for that
> domain, could flushing it cause a problem?

No, that can't cause a problem. An io/tlb flush for the device is just a
message that the device should invalidate its own tlb. The device can't
know and doesn't need to know whether the page-tables it used to fill
the tlb really changed.

As it looks, the problem we are seeing here is that we are sending a
large amount of these requests to the GPU device, and wait for its
completion every time. This shouldn't be a problem for ATS devices, but
the GPU here seems to fail at some point and doesn't answer to the
invalidation request anymore, causing the completion-wait loop timeouts.

Arindam's patch makes the high flush-frequency less likely, but it can
still happen, depending on how the GPU is used. So its the best to
keep ATS disabled on the device as it doesn't work correctly and we risk
running in the same problem again when we leave it enabled and just make
the trigger less likely.

	Joerg

Thread

[PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <joro@8bytes.org> - 2017-03-28 14:20 +0200
  RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:20 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-03-28 22:30 +0200
      RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:40 +0200
        Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-28 23:00 +0200
          RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 23:20 +0200
            Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 00:30 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 09:20 +0200
                Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 11:50 +0200
                RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 11:50 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-29 18:30 +0200
  Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Bjorn Helgaas <helgaas@kernel.org> - 2017-04-04 18:50 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-04-07 14:40 +0200

csiph-web