[PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	[PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS
Date	2017-03-28 14:20 +0200
Message-ID	<tpYgq-7p2-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Joerg Roedel <jroedel@suse.de>

ATS is broken on these devices. Under invalidation load, the
GPU does not reply to invalidations anymore, causing
Completion-wait loop timeouts on the AMD IOMMU driver side.
Fix it by not enabling ATS on these devices.

Note that below mentioned commit is not broken, it just
triggers the issue because it might cause invalidation
storms on devices.

Fixes: b1516a14657a ('iommu/amd: Implement flush queue')
Reported-by: Daniel Drake <drake@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Alexander Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 drivers/pci/ats.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c
index eeb9fb2..711bdb2 100644
--- a/drivers/pci/ats.c
+++ b/drivers/pci/ats.c
@@ -17,10 +17,18 @@
 
 #include "pci.h"
 
+static const struct pci_device_id broken_ats_tbl[] = {
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x98e4) }, /* AMD Stoney GPU part */
+	{ 0 }
+};
+
 void pci_ats_init(struct pci_dev *dev)
 {
 	int pos;
 
+	if (pci_match_id(broken_ats_tbl, dev))
+		return;
+
 	pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ATS);
 	if (!pos)
 		return;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <joro@8bytes.org> - 2017-03-28 14:20 +0200
  RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:20 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-03-28 22:30 +0200
      RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 22:40 +0200
        Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-28 23:00 +0200
          RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-28 23:20 +0200
            Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 00:30 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 09:20 +0200
                Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS 'Joerg Roedel' <jroedel@suse.de> - 2017-03-29 11:50 +0200
                RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Nath, Arindam" <Arindam.Nath@amd.com> - 2017-03-29 11:50 +0200
              RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-03-29 18:30 +0200
  Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Bjorn Helgaas <helgaas@kernel.org> - 2017-04-04 18:50 +0200
    Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Joerg Roedel <jroedel@suse.de> - 2017-04-07 14:40 +0200

csiph-web