[PATCH] reduce the time of finding symbols for module

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Zhou Chengming <zhouchengming1@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] reduce the time of finding symbols for module
Date	Tue, 28 Mar 2017 04:10:02 +0200
Message-ID	<tpOK6-DA-5@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 1.8.3.1
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.175.113.25]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020202.58D9C4DB.0057,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	0ee2f847e4d4edaa68a6128db7c7a7a9
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	<jpoimboe@redhat.com>, <jeyu@redhat.com>, <jikos@kernel.org>, <mbenes@suse.cz>, <pmladek@suse.com>, <huawei.libin@huawei.com>, <zhouchengming1@huawei.com>
X-Original-Date	Tue, 28 Mar 2017 10:02:15 +0800
X-Original-Message-ID	<1490666535-19192-1-git-send-email-zhouchengming1@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610257

Show key headers only | View raw

It's reported that the time of insmoding a klp.ko for one of our
out-tree modules is too long.

~ time sudo insmod klp.ko
real	0m23.799s
user	0m0.036s
sys	0m21.256s

Then we found the reason: klp_find_object_symbol() uses the interface
kallsyms_on_each_symbol() even for finding module symbols, so will waste
a lot of time. This patch changes it to use module_kallsyms_on_each_symbol()
for modules symbols.

After we apply this patch, the sys time reduced dramatically.
~ time sudo insmod klp.ko
real	0m1.007s
user	0m0.032s
sys	0m0.924s

Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
---
 kernel/livepatch/core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index af46438..b4b8bb0 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -182,7 +182,10 @@ static int klp_find_object_symbol(const char *objname, const char *name,
 	};
 
 	mutex_lock(&module_mutex);
-	kallsyms_on_each_symbol(klp_find_callback, &args);
+	if (objname)
+		module_kallsyms_on_each_symbol(klp_find_callback, &args);
+	else
+		kallsyms_on_each_symbol(klp_find_callback, &args);
 	mutex_unlock(&module_mutex);
 
 	/*
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] reduce the time of finding symbols for module Zhou Chengming <zhouchengming1@huawei.com> - 2017-03-28 04:10 +0200
  Re: [PATCH] reduce the time of finding symbols for module Miroslav Benes <mbenes@suse.cz> - 2017-03-28 11:10 +0200
    Re: [PATCH] reduce the time of finding symbols for module zhouchengming <zhouchengming1@huawei.com> - 2017-03-28 13:10 +0200
      Re: [PATCH] reduce the time of finding symbols for module Miroslav Benes <mbenes@suse.cz> - 2017-03-28 13:20 +0200
        Re: [PATCH] reduce the time of finding symbols for module zhouchengming <zhouchengming1@huawei.com> - 2017-03-28 15:00 +0200
        Re: [PATCH] reduce the time of finding symbols for module Jessica Yu <jeyu@redhat.com> - 2017-03-29 02:10 +0200
          Re: [PATCH] reduce the time of finding symbols for module Li Bin <huawei.libin@huawei.com> - 2017-03-29 04:00 +0200
            Re: [PATCH] reduce the time of finding symbols for module Jessica Yu <jeyu@redhat.com> - 2017-03-29 21:10 +0200

csiph-web