Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check
Date	2017-03-28 04:00 +0200
Message-ID	<tpOAq-iy-3@gated-at.bofh.it> (permalink)
References	<to8tz-116-15@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Dan Carpenter <dan.carpenter@oracle.com> writes:

> We don't call the remove() function unless probe() succeeds so "oud"
> can't be NULL here.  Plus, if it were NULL, we dereference it on the
> next line so it would crash anyway.

Applied to 4.12/scsi-queue (by hand).

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: osd_uld: remove an unneeded NULL check Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-23 11:50 +0100
  Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check Boaz Harrosh <ooo@electrozaur.com> - 2017-03-23 20:40 +0100
  Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-28 04:00 +0200

csiph-web