Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1610430

Re: [PATCH] reduce the time of finding symbols for module

From Miroslav Benes <mbenes@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] reduce the time of finding symbols for module
Date 2017-03-28 11:10 +0200
Message-ID <tpVix-5md-3@gated-at.bofh.it> (permalink)
References <tpOK6-DA-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

On Tue, 28 Mar 2017, Zhou Chengming wrote:

> It's reported that the time of insmoding a klp.ko for one of our
> out-tree modules is too long.
> 
> ~ time sudo insmod klp.ko
> real	0m23.799s
> user	0m0.036s
> sys	0m21.256s

Is this stable through several (>=10) runs? 23 seconds are really 
suspicious. Yes, there is a linear search through all the kallsyms in 
kallsyms_on_each_symbol(), but there are something like 70k symbols on my 
machine (that is, way less than 1M). 23 seconds are somewhat unexpected.

If it is a problem, can we fix kallsyms_on_each_symbol() and replace the 
linear search with something better? All users would benefit...

Thanks,
Miroslav

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] reduce the time of finding symbols for module Zhou Chengming <zhouchengming1@huawei.com> - 2017-03-28 04:10 +0200
  Re: [PATCH] reduce the time of finding symbols for module Miroslav Benes <mbenes@suse.cz> - 2017-03-28 11:10 +0200
    Re: [PATCH] reduce the time of finding symbols for module zhouchengming <zhouchengming1@huawei.com> - 2017-03-28 13:10 +0200
      Re: [PATCH] reduce the time of finding symbols for module Miroslav Benes <mbenes@suse.cz> - 2017-03-28 13:20 +0200
        Re: [PATCH] reduce the time of finding symbols for module zhouchengming <zhouchengming1@huawei.com> - 2017-03-28 15:00 +0200
        Re: [PATCH] reduce the time of finding symbols for module Jessica Yu <jeyu@redhat.com> - 2017-03-29 02:10 +0200
          Re: [PATCH] reduce the time of finding symbols for module Li Bin <huawei.libin@huawei.com> - 2017-03-29 04:00 +0200
            Re: [PATCH] reduce the time of finding symbols for module Jessica Yu <jeyu@redhat.com> - 2017-03-29 21:10 +0200

csiph-web