Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels
Date	2017-03-27 15:50 +0200
Message-ID	<tpDbY-nU-25@gated-at.bofh.it> (permalink)
References	<toHrj-ZP-3@gated-at.bofh.it> <toOMa-67F-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/25/2017 01:51 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Shuah Khan <shuahkh@osg.samsung.com> writes:
>> This patch series consists of two fixes and changes to goto labels
> 
> we *NEVER* put cleanups and fixes together.
> 
>> to use meaningful names.
>>
>> While working on goto label changes, I noticed  put_sync calls without
>> successful get_sync in error legs.  The first two patches are the fixes
>> and the rest of the patches are goto label changes.
> 
> so, you mean to say that you're adding regressions because you *THOUGHT*
> there was a bug there, right? Read the docs ;-)
> 

Sorry for the noise. Thanks for pointing this out.

-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 7/7] usb: dwc3: host: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
    Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
  [PATCH 3/7] usb: dwc3: core: change goto labels to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 6/7] usb: dwc3: gadget: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 4/7] usb: dwc3: exynos: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 5/7] usb: dwc3: omap: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
    Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-27 15:50 +0200

csiph-web