Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609116

Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works

From Felipe Balbi <balbi@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works
Date 2017-03-25 09:00 +0100
Message-ID <toOMa-67F-11@gated-at.bofh.it> (permalink)
References <toHrj-ZP-3@gated-at.bofh.it> <toHrk-ZP-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

Shuah Khan <shuahkh@osg.samsung.com> writes:
> dwc3_omap_probe() does pm_runtime_put_sync() in its err1 handling when
> pm_runtime_get_sync() fails.  Fix it to do put_sync only when get_sync
> succeeds.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>

sorry, not taking any of these pointless patches. There's nothing wrong
with the goto labels, there's nothing wrong with the error path in any
of these drivers.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 7/7] usb: dwc3: host: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
    Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
  [PATCH 3/7] usb: dwc3: core: change goto labels to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 6/7] usb: dwc3: gadget: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 4/7] usb: dwc3: exynos: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 5/7] usb: dwc3: omap: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
    Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-27 15:50 +0200

csiph-web